Repository navigation
Conversation
k4y3ff
reviewed
Sep 29, 2026
|
|
||
| # Install dependencies (this may take a minute) | ||
| npm install | ||
| npm ci |
There was a problem hiding this comment.
I am not a Node developer, so I will ask a potentially silly question: is this line correct? Should candidates indeed be installing the code in this repo using a command called npm ci?
I would have guessed based on the name that npm ci was for... CI? 😂
There was a problem hiding this comment.
Thanks, you learn something new everyday. 🤣
k4y3ff
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrcand update candidate/contributor setup to usenpm ciTest coverage
The 12 tests cover:
Verification
npm ci --ignore-scripts --no-auditCI=true npm test -- --watchAll=false— 3 suites, 12 tests passednpm run build— compiled successfullygit diff --check— passedThis PR is intentionally independent of #12.